Show Controls And Update Grids With Generated Content #6553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When the entries inside a grid are generated from something like a map expression, none of the grid handling works for when the elements are selected.
Fix:
Mostly this uses a function to look up the hierarchy for an uninherited grid layout system. As previously the assumption was that the direct parent of a grid item within our hierarchy would be the grid.
Video:
https://github.com/user-attachments/assets/609db057-30a5-47e8-bd15-decc71ec671b
Commit Details:
isGridCell
.findOriginalGrid
utility function.layoutSystemForChildrenInherited
tofillLayoutSystemForChildrenFromAncestors
.useGridData
now usesfindOriginalGrid
to look up the hierarchy to find the grid we're interested in.resizeGridStrategy
now usesfindOriginalGrid
to find the correct element to update.layoutSystemForChildrenInherited
to false.Manual Tests:
I hereby swear that: