-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(import): detect node built-ins #6609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14993 Bundle Size — 58.04MiB (~+0.01%).3b26095(current) vs d1d46c1 master#14991(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch feat/server-packages-import Project dashboard Generated by RelativeCI Documentation Report issue |
Rheeseyb
reviewed
Oct 31, 2024
Rheeseyb
approved these changes
Oct 31, 2024
seanparsons
approved these changes
Nov 1, 2024
liady
added a commit
that referenced
this pull request
Dec 13, 2024
This PR adds the ability to detect Node built-ins that are being imported. **Notes:** - We currently detect all imports in project files, without checking if the importing file is in the import chain of the app itself. This _may_ result in false positives, if one of the files in the project that does not belong to the app imports a Node module. - For that reason - currently this only triggers a "warning" and not a critical error. - We compare the built-ins that we find with the project dependencies, in case some of them are shimmed. - We're using a static list taken from here: https://github.com/sindresorhus/builtin-modules. We can't use the package directly since it is an ESM module, and our tests cannot import it, and in any case all it does is exporting this JSON. If you clone this branch you can test it using http://localhost:8000/p?accessLevel=public&clone=liady/utopia-vite-project - I added an `import * as fs from 'fs'` there to test this functionality. (don't forget to turn on the `Import Wizard` feature flag) <img width="658" alt="image" src="https://github.com/user-attachments/assets/c4ddedef-d863-45fa-89f6-63c7ee6cd4f4"> **Manual Tests:** I hereby swear that: - [X] I opened a hydrogen project and it loaded - [X] I could navigate to various routes in Play mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to detect Node built-ins that are being imported.
Notes:
If you clone this branch you can test it using http://localhost:8000/p?accessLevel=public&clone=liady/utopia-vite-project - I added an
import * as fs from 'fs'
there to test this functionality. (don't forget to turn on theImport Wizard
feature flag)Manual Tests:
I hereby swear that: