feat(import): allow continuing the import after an error #6614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15023 Bundle Size — 58.04MiB (~+0.01%).474a2b1(current) vs d1d46c1 master#15007(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15023 |
Baseline #15007 |
|
|---|---|---|
 Initial JS |
41.02MiB(+0.01%) |
41.02MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.36% |
0% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4165 |
4165 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.31% |
27.31% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15023 |
Baseline #15007 |
|
|---|---|---|
| JS |
58.04MiB (~+0.01%) |
58.03MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feat/continue-import Project dashboard
Generated by RelativeCI Documentation Report issue
liady
commented
Nov 4, 2024
| @@ -38,25 +51,10 @@ export const ImportWizard = React.memo(() => { | |||
| e.stopPropagation() | |||
| }, []) | |||
|
|
|||
| const totalImportResult: ImportOperationResult | null = React.useMemo(() => { | |||
There was a problem hiding this comment.
moved to a different file
liady
commented
Nov 4, 2024
| return ( | ||
| <React.Fragment> | ||
| <div style={textStyle}>Error Importing Project</div> | ||
| <Button style={buttonStyle}>Import A Different Project</Button> | ||
| <div style={textStyle}> |
There was a problem hiding this comment.
if we're in an error mode (but not a critical error), show a button for Continue Anyway
liady
commented
Nov 4, 2024
| dispatch([updateImportStatus(importStatus)]) | ||
| } | ||
|
|
||
| export function getTotalImportStatusAndResult(importState: ImportState): TotalImportResult { |
There was a problem hiding this comment.
this logic was moved here from import-wizard.tsx
liady
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics and
bkrmendy
bkrmendy
approved these changes
Nov 5, 2024
Rheeseyb
approved these changes
Nov 5, 2024
liady
added a commit
that referenced
this pull request
Dec 13, 2024
This PR adds the ability to control the import process after an error: 1. Import a different project 2. Decide to continue anyway (for example to correct it using our editor). This PR distinguishes between an `Error` (that can be continued) and a `Critical Error` (for example a non-existent repo) - that we cannot recover from. **PR details:** 1. In [editor/src/core/shared/github/operations/load-branch.ts](https://github.com/concrete-utopia/utopia/pull/6614/files#diff-3c1474cac72b0e757d951539630bd72175135c05eddbff91d9f10639d2796440) this PR adds the ability to stop before dependencies fetching and resume afterwards 2. In [editor/src/components/editor/import-wizard/import-wizard.tsx](https://github.com/concrete-utopia/utopia/pull/6614/files#diff-a1ec93eec4b0720f01ff6ec77bb4efb6cc3ac0ba4297d3fe7bb77049c601ca94) this PR adds the UI for displaying the correct status/buttons according to the current import state. 3. The rest of the changes are mostly actions/state changes. For example this flow: 1. Importing a non-existing repo (critical error) 2. Then importing a project with errors (TS/server packages, etc), choosing to continue importing 3. Deciding to import a different project - which is a success <video src="https://github.com/user-attachments/assets/39eaeedd-14fd-4819-b590-39a92629ad8e"></video> Current design: <img width="693" alt="image" src="https://github.com/user-attachments/assets/a609068f-dece-4448-a31d-c266969a6341"> **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to control the import process after an error:
This PR distinguishes between an
Error(that can be continued) and aCritical Error(for example a non-existent repo) - that we cannot recover from.PR details:
For example this flow:
Monosnap.screencast.2024-11-04.19-04-09.mp4
Current design:
Manual Tests:
I hereby swear that: