feat(loading): merge github fetch with the loading bar #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15275 Bundle Size — 58.12MiB (+0.01%).098ccd0(current) vs d1d46c1 master#15274(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15275 |
Baseline #15274 |
|
|---|---|---|
 Initial JS |
41.09MiB(+0.02%) |
41.09MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.18% |
0% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4174(+0.02%) |
4173 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.28% |
27.28% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 2 regressions
| Current #15275 |
Baseline #15274 |
|
|---|---|---|
| JS |
58.11MiB (+0.01%) |
58.1MiB |
| HTML |
8.73KiB (+18.14%) |
7.39KiB |
Bundle analysis report Branch feat/loading-bar Project dashboard
Generated by RelativeCI Documentation Report issue
2 tasks
liady
changed the title
liady
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics and
bkrmendy
liady
added a commit
that referenced
this pull request
Nov 25, 2024
This PR changes the UI of the import wizard to better reflect errors in the header. Note: this is a part of a larger change in the import flow (using the loading screen - PR #6630), but was extracted to minimize PR size since it can be reviewed independently. Please review only the wizard appearance, the flow itself will be changed. <video src="https://github.com/user-attachments/assets/cee5fa7d-c161-47bb-a182-369f063fdf4a"></video> **Manual Tests:** I hereby swear that: - [X] I opened a hydrogen project and it loaded - [X] I could navigate to various routes in Play mode
seanparsons
reviewed
Nov 25, 2024
| const themeStyle = | ||
| currentTheme === 'dark' | ||
| ? ` | ||
| .editor-loading-screen { background-color: ${colorTheme.bg6.value} } |
There was a problem hiding this comment.
Does this mean we're relying on some defaults for light mode? This feels a little like we're kinda patching it rather than fixing it.
There was a problem hiding this comment.
in a sense this is "patching", since we want to match the CSS behavior in index.html where the dark mode "overrides" the light mode defaults (that also apply here).
I didn't want to change anything in case we have a light theme, so to not create a possible divergence in color from the light "default" that is defined in the base index.html css.
seanparsons
approved these changes
Nov 25, 2024
balazsbajorics
approved these changes
Nov 25, 2024
liady
added a commit
that referenced
this pull request
Dec 13, 2024
This PR changes the UI of the import wizard to better reflect errors in the header. Note: this is a part of a larger change in the import flow (using the loading screen - PR #6630), but was extracted to minimize PR size since it can be reviewed independently. Please review only the wizard appearance, the flow itself will be changed. <video src="https://github.com/user-attachments/assets/cee5fa7d-c161-47bb-a182-369f063fdf4a"></video> **Manual Tests:** I hereby swear that: - [X] I opened a hydrogen project and it loaded - [X] I could navigate to various routes in Play mode
liady
added a commit
that referenced
this pull request
Dec 13, 2024
This PR adds the loading stages to the loading bar screen and progress bar. Stages for GH import: 1. Loading Editor... 2. Fetching <repo name> 3. Parsing files 4. Fetching dependencies Stages for project load (we reverse the order in our project load): 1. Fetching dependencies 2. Parsing files If everything is validated correctly - it just shows the editor with the project ready to be worked on. If not - it shows an error modal (its UI was slightly changed in #6677 to better reflect errors). It also adds support for Dark mode. **Note:** - The new logic is almost entirely in [editor/src/components/editor/loading-screen.tsx](https://github.com/concrete-utopia/utopia/pull/6630/files#diff-5aa4d7e811e0bfb07a60910e517fe3a01cd270c9b4fd05132e513d939d69f769) - There is a jump in the progress bar since these are actually two DOM elements, one that is rendered before the React is loaded and a React component that replaces it after the React code is loaded. This jump will be fixed in a subsequent PR. - Currently the progress bar is "static" (advances by time and not stages). This will be changed in (the same) subsequent PR. <video src="https://github.com/user-attachments/assets/a6d52f3d-b27b-4110-be1e-a7f213f563ab"></video> **Manual Tests:** I hereby swear that: - [X] I opened a hydrogen project and it loaded - [X] I could navigate to various routes in Play mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the loading stages to the loading bar screen and progress bar.
Stages for GH import:
Stages for project load (we reverse the order in our project load):
If everything is validated correctly - it just shows the editor with the project ready to be worked on. If not - it shows an error modal (its UI was slightly changed in #6677 to better reflect errors).
It also adds support for Dark mode.
Note:
Monosnap.screencast.2024-11-24.18-08-46.mp4
Manual Tests:
I hereby swear that: