-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): breakpoint data display (spike, wip) #6690
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liady
changed the title
feat(editor): breakpoint data display spike
feat(editor): breakpoint data display (spike, wip)
Dec 2, 2024
#15409 Bundle Size — 58.23MiB (+0.03%).0f22af2(current) vs d1d46c1 master#15407(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
Current #15409 |
Baseline #15407 |
|
---|---|---|
Initial JS | 41.19MiB (+0.05% ) |
41.18MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 18.24% |
18.12% |
Chunks | 20 |
20 |
Assets | 22 |
22 |
Modules | 4191 (+0.05% ) |
4189 |
Duplicate Modules | 213 |
213 |
Duplicate Code | 27.24% |
27.24% |
Packages | 477 |
477 |
Duplicate Packages | 70 |
70 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #15409 |
Baseline #15407 |
|
---|---|---|
JS | 58.22MiB (+0.03% ) |
58.2MiB |
HTML | 9.4KiB (-0.21% ) |
9.42KiB |
Bundle analysis report Branch feat/breakpoint-data-display-spi... Project dashboard
Generated by RelativeCI Documentation Report issue
Temporarily closing until we pick the track back up.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: most of the functionality here was merged to master, this functionality wasn't merged:
This PR displays the correct breakpoint data in the controllers, and updates the relevant breakpoint
Monosnap.screencast.2024-12-04.19-40-23.mp4
Manual Tests:
I hereby swear that: