Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): breakpoint data display (spike, wip) #6690

Closed
wants to merge 26 commits into from

Conversation

liady
Copy link
Contributor

@liady liady commented Dec 2, 2024

UPDATE: most of the functionality here was merged to master, this functionality wasn't merged:

  1. Scene resize buttons (desing needed)
  2. Indicators on controls that the value comes from a breakpoint (design needed)

This PR displays the correct breakpoint data in the controllers, and updates the relevant breakpoint

Monosnap.screencast.2024-12-04.19-40-23.mp4

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

@liady liady changed the title feat(editor): breakpoint data display spike feat(editor): breakpoint data display (spike, wip) Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Try me

Copy link

relativeci bot commented Dec 2, 2024

#15409 Bundle Size — 58.23MiB (+0.03%).

0f22af2(current) vs d1d46c1 master#15407(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#15409
     Baseline
#15407
Regression  Initial JS 41.19MiB(+0.05%) 41.18MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.24% 18.12%
No change  Chunks 20 20
No change  Assets 22 22
Change  Modules 4191(+0.05%) 4189
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.24% 27.24%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#15409
     Baseline
#15407
Regression  JS 58.22MiB (+0.03%) 58.2MiB
Improvement  HTML 9.4KiB (-0.21%) 9.42KiB

Bundle analysis reportBranch feat/breakpoint-data-display-spi...Project dashboard


Generated by RelativeCIDocumentationReport issue

@liady liady added the Spike Experiment, trial, investigation label Dec 13, 2024
@liady
Copy link
Contributor Author

liady commented Dec 15, 2024

Temporarily closing until we pick the track back up.
most of the functionality here was merged to master, this functionality wasn't merged:

  1. Scene resize buttons (desing needed)
  2. Indicators on controls that the value comes from a breakpoint (design needed)

@liady liady closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spike Experiment, trial, investigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant