feat(editor): pass scene size to style plugins #6715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try me(deploying...) |
#15412 Bundle Size — 58.22MiB (+0.02%).4d676f7(current) vs d1d46c1 master#15407(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15412 |
Baseline #15407 |
|
|---|---|---|
 Initial JS |
41.19MiB(+0.02%) |
41.18MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.24% |
18.12% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4190(+0.02%) |
4189 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.24% |
27.24% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15412 |
Baseline #15407 |
|
|---|---|---|
| JS |
58.21MiB (+0.02%) |
58.2MiB |
| HTML |
9.4KiB (-0.21%) |
9.42KiB |
Bundle analysis report Branch feat/pass-scene-size Project dashboard
Generated by RelativeCI Documentation Report issue
liady
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics and
bkrmendy
bkrmendy
approved these changes
Dec 10, 2024
ruggi
approved these changes
Dec 11, 2024
liady
added a commit
that referenced
this pull request
Dec 13, 2024
This prep PR adds the ability to pass the Scene size to the Tailwind plugin/ This was extracted from the spike since it added small changes in many files. **Details:** - We need the Scene size in [tailwind-style-plugin.ts](https://github.com/concrete-utopia/utopia/pull/6715/files#diff-ad30d4bf205861b9efac9bb4bdb2bb68707cace215f64915244c46dbfab0607dR23-R25) to be able (in the next PR) to calculate the matching breakpoint. - We get the Scene size in `getContainingSceneWidth` in [responsive-utils.ts](https://github.com/concrete-utopia/utopia/pull/6715/files#diff-4f8de694cb6cb8852ff046766f5015a01f9567d4c3b7472bbac36358b52932aaR7-R16) and we pass it to the Tailwind plugin. - The rest of the changes are just passing down this data. This PR doesn't change any functionality, but is merely a prep PR for the next, functional one. **Manual Tests:** I hereby swear that: - [X] I opened a hydrogen project and it loaded - [X] I could navigate to various routes in Play mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prep PR adds the ability to pass the Scene size to the Tailwind plugin/
This was extracted from the spike since it added small changes in many files.
Details:
getContainingSceneWidthin responsive-utils.ts and we pass it to the Tailwind plugin.This PR doesn't change any functionality, but is merely a prep PR for the next, functional one.
Manual Tests:
I hereby swear that: