Allow and validate schema_version key in v1 recipes
#2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the v1 recipes to contain a top-level `schema_version` key, and expect it to be ordered first. The key is defined in CEP 14: https://conda.org/learn/ceps/cep-0014#schema-version Fixes conda-forge#2201
For the time being, just verify that `schema_version` is 1 when using `recipe.yaml` format, and refuse to lint if it is not. In the future, the code will probably need to be adapted to change `recipe_version` based on `schema_version`.
|
thanks! Once this is in, I'll try transitioning the rest of the feedstocks I maintain to rattler build with conda-recipe-manager and see if there are any other hiccups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)Allow the
schema_versionkey in v1 recipes, and validate that it has a value of 1.For testing:
schema_versionis covered by most of the existing testsschema_version: 1, I've modified ourtorchvision.recipeschema_version, I've added an explicit test