Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cbc from coin-or-cbc rather than binaries in pulp tar-ball #41

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Use cbc from coin-or-cbc rather than binaries in pulp tar-ball #41

wants to merge 7 commits into from

Conversation

peterjc
Copy link

@peterjc peterjc commented Aug 15, 2024 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

If this works, it would close #27 and #40 by using the external dependency for the cbc binaries, rather than the limited set of pre-compiled cbc binaries bundled with the pulp tar-ball.

@peterjc
Copy link
Author

peterjc commented Aug 15, 2024

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • The source section contained an unexpected subsection name. patch is not a valid subsection name.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

peterjc
peterjc commented Aug 15, 2024
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@peterjc
Copy link
Author

peterjc commented Aug 15, 2024

@conda-forge-admin, please rerender

@peterjc
Copy link
Author

peterjc commented Aug 15, 2024 •
edited
Loading

Hmm. This looks like a common clue (even on the Mac builds):

Processing $SRC_DIR
  Added file://$SRC_DIR to build tracker '/tmp/pip-build-tracker-pbfcgnix'
  Running setup.py (path:$SRC_DIR/setup.py) egg_info for package from file://$SRC_DIR
  Created temporary directory: /tmp/pip-pip-egg-info-s0h25hal
  Preparing metadata (setup.py): started
  Running command python setup.py egg_info
  /home/conda/feedstock_root/build_artifacts/pulp_1723724843211/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.9/site-packages/setuptools/_distutils/dist.py:268: UserWarning: Unknown distribution option: 'test_suite'
    warnings.warn(msg)
  running egg_info
  creating /tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info
  writing /tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info/PKG-INFO
  writing dependency_links to /tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info/dependency_links.txt
  writing entry points to /tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info/entry_points.txt
  writing top-level names to /tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info/top_level.txt
  writing manifest file '/tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info/SOURCES.txt'
  error: package directory 'pulp/solverdir/cbc/linux/32' does not exist
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

Update: I'd left a delete command in before running pip install. Doh.

@peterjc
Copy link
Author

peterjc commented Aug 15, 2024

Progress, my mistake again:

rm: cannot remove ‘/home/conda/feedstock_root/build_artifacts/pulp_1723725844498/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.8/site-packages/pulp/solverdir/cbc’: Is a directory

@peterjc
Copy link
Author

peterjc commented Aug 15, 2024

Just a HTTP 502 BAD GATEWAY for the linux_aarch64_python3.9.____cpython run.

And an easy fix for the Windows failure:

'rm' is not recognized as an internal or external command,
operable program or batch file.

@peterjc
Copy link
Author

peterjc commented Aug 15, 2024

Is there a way to download the packages built on this PR for local testing? (BioConda has a bot to help do that - I can't see any artifact links on Azure here)

@tkralphs
Copy link

You have to set up the workflow to archive artifacts using something like actions/upload-artifact, it's not automatic.

@peterjc peterjc mentioned this pull request Aug 22, 2024
Open
@peterjc peterjc mentioned this pull request Dec 16, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopher-schroeder christopher-schroeder Awaiting requested review from christopher-schroeder christopher-schroeder is a code owner

@johanneskoester johanneskoester Awaiting requested review from johanneskoester johanneskoester is a code owner

@venaturum venaturum Awaiting requested review from venaturum venaturum is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to depending on coin-or-cbc?
2 participants
@peterjc @tkralphs