Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace coincbc by coin-or-cbc #23

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FelixMoelder
Copy link

@FelixMoelder FelixMoelder commented Apr 30, 2021

This PR just replaces coincbc by coin-or-cbc as the later package is newer and probably cleaner due to a split up in several coin-or-* packages.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@FelixMoelder
Copy link
Author

@conda-forge-admin, please rerender

Copy link
Member

@mbargull mbargull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coin-or-cbc seems to be broken :/.
see conda-forge/coincbc-feedstock#45 (comment)

@mbargull
Copy link
Member

We should also add a proper test solve here to ensure it is able to successfully run with the solver dependencies.

@peterjc
Copy link

peterjc commented Dec 16, 2024

I believe #41 would replace this older PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants