Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused patch; update test command and requirements #26

Merged
merged 5 commits into from
May 30, 2020

Conversation

bnavigator
Copy link
Contributor

@bnavigator bnavigator commented May 30, 2020

As discussed in python-control/Slycot#98 (comment)

I am not very familiar with the conda-forge and smithy workflow, but let's try:

Checklist

Fixes #25

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bnavigator
Copy link
Contributor Author

Windows, Python 3.8:

================================== FAILURES ===================================
____________________________ test_xerbla_override _____________________________

    def test_xerbla_override():
        """Test that Fortran routines calling XERBLA do not print to stdout."""
    
        try:
            out = subprocess.check_output([sys.executable, '-c', CODE],
                                           stderr=subprocess.STDOUT,
                                           universal_newlines=True)
        except subprocess.CalledProcessError as cpe:
            raise RuntimeError("Trying to call _wrapper.ab08nd() failed with "
                               "returncode {}.\n"
                               "Captured STDOUT: \n {}\n"
                               "Captured STDERR: \n {}\n"
                               "".format(cpe.returncode, cpe.stdout, cpe.stderr))
    
        outlines = out.splitlines()
        assert len(outlines) == 2
>       assert outlines[0] == _wrapper.__file__
E       AssertionError: assert 'D:\\bld\\sly...win_amd64.pyd' == 'D:\\bld\\sly...win_amd64.pyd'
E         Skipping 42 identical trailing characters in diff, use -v to show
E         - %PREFIX%\Lib\site-p
E         ?                                       ^
E         + %PREFIX%\lib\site-p
E         ?                                       ^

Welcome to the world of case-insensitive path names 🤦

Going to fix this by skipping the test until we fix it in the Slycot source.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [39]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@moorepants
Copy link
Contributor

LGMT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tests may no longer be run on the feedstock in version 0.4.0.0
3 participants