Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Update KBS for v0.8.2 release #319

Merged

Conversation

portersrc
Copy link
Member

@portersrc portersrc commented Feb 9, 2024

Preparing KBS for v0.8.2 following discussion from #312

@portersrc portersrc requested a review from sameo as a code owner February 9, 2024 19:36
@portersrc portersrc force-pushed the changes-for-v0.8.2-release branch from 2eed4ee to 37988bc Compare February 9, 2024 20:40
@portersrc portersrc force-pushed the changes-for-v0.8.2-release branch from 37988bc to dcf8ef8 Compare February 9, 2024 20:43
@portersrc portersrc changed the title Release: Update kbs kustomization for v0.8.2 release Release: Bump KBS for v0.8.2 release Feb 9, 2024
@portersrc portersrc changed the title Release: Bump KBS for v0.8.2 release Release: Update KBS for v0.8.2 release Feb 9, 2024
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implies two changes to the release process.

First, we're getting rid of the release workflows. Note that these workflows did not run any additional tests, they just built the images and pushed them. Instead, we can just tag the latest staged images as the release images (assuming we're happy with them). In the future we should add a script to do this. The advantage here is that it eliminates the possibility of the release workflows breaking. This has happened a couple of times in the past and it really slows things down. If the release workflows break, we have to cut another release to fix them.

Second, the docker-compose file is going to remain pointing at the head. This deployment will build all the containers from source. On the other hand the Kubernetes config will always pointed to the images corresponding to the latest release. This is a compromise between supporting developers who want to build from the latest source and consumers who want something stable.

These changes were discussed on #312 and on Slack, but this release falls in a window where some maintainers are on vacation. These changes are not set in stone. If this doesn't turn out to be an improvement on the existing process we can revert for the next release.

Note also that there is a small issue with the nightly builds. This is not considered significant. To be cautious we are putting off the fix until after this release.

@fitzthum fitzthum merged commit edc416e into confidential-containers:main Feb 9, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants