-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initdata: enhance the initdata spec for PeerPod and IBM SE #450
initdata: enhance the initdata spec for PeerPod and IBM SE #450
Conversation
Added IBM SE fields for initdata Added examples for digest calculation in PeerPod Signed-off-by: Qi Feng Huo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @huoqifeng , as initdata might not only face to CoCo. I suggest have detailed information, such as the content of the toml of this PR be in another doc like in peerpod. In this document, only leave a link to that doc. Just like https://github.com/confidential-containers/trustee/blob/main/kbs/docs/initdata.md#confidential-containers does. wdyt?
OK, I'll move these contents to https://github.com/confidential-containers/cloud-api-adaptor and make a link in this PR. Thanks! @Xynnn007 |
Waiting the linked page to be available in https://github.com/confidential-containers/cloud-api-adaptor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added initdata link in PeerPod Signed-off-by: Qi Feng Huo <[email protected]>
3447d68
to
4d5f656
Compare
@Xynnn007 the PR in PeerPod has been merged and the link updated in this PR, may you please check it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added IBM SE fields for initdata
Added examples for digest calculation in PeerPod
Depends on: