Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initdata: enhance the initdata spec for PeerPod and IBM SE #450

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

huoqifeng
Copy link
Contributor

@huoqifeng huoqifeng commented Jul 31, 2024

Added IBM SE fields for initdata
Added examples for digest calculation in PeerPod

Depends on:

Added IBM SE fields for initdata
Added examples for digest calculation in PeerPod

Signed-off-by: Qi Feng Huo <[email protected]>
@huoqifeng
Copy link
Contributor Author

CC @Xynnn007 @fitzthum @ChengyuZhu6 @mkulke @jialez0

Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @huoqifeng , as initdata might not only face to CoCo. I suggest have detailed information, such as the content of the toml of this PR be in another doc like in peerpod. In this document, only leave a link to that doc. Just like https://github.com/confidential-containers/trustee/blob/main/kbs/docs/initdata.md#confidential-containers does. wdyt?

@huoqifeng
Copy link
Contributor Author

Hi @huoqifeng , as initdata might not only face to CoCo. I suggest have detailed information, such as the content of the toml of this PR be in another doc like in peerpod. In this document, only leave a link to that doc. Just like https://github.com/confidential-containers/trustee/blob/main/kbs/docs/initdata.md#confidential-containers does. wdyt?

OK, I'll move these contents to https://github.com/confidential-containers/cloud-api-adaptor and make a link in this PR. Thanks! @Xynnn007

@huoqifeng
Copy link
Contributor Author

Waiting the linked page to be available in https://github.com/confidential-containers/cloud-api-adaptor

Copy link
Member

@ChengyuZhu6 ChengyuZhu6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Added initdata link in PeerPod

Signed-off-by: Qi Feng Huo <[email protected]>
@huoqifeng
Copy link
Contributor Author

@Xynnn007 the PR in PeerPod has been merged and the link updated in this PR, may you please check it?

Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xynnn007 Xynnn007 merged commit 79722e7 into confidential-containers:main Aug 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants