Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kbs/plugins/resource: Add ID_KEY resource backend #698
base: main
Are you sure you want to change the base?
kbs/plugins/resource: Add ID_KEY resource backend #698
Changes from all commits
7dc01a1
a4cfc1a
5f684a7
2ccfeed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is going to work.
When making a resource request, the TEE public key is not in the request body. It's in the attestation token. Check out how we extract the public key here when we use it to encrypt the response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't using the TEE public key. This is because I'm only supporting ECDH, and not leaving open the use of RSA like JWK's allow. Would you prefer it use JWK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you're expecting the request to have an additional key in it? That seems like an extension of the protocol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under impression the protocol was a bit flexible with this. I'm using the protocol in an unconventional way anyway w/r/t needing to first fetch the server's ECDH public key before actually requesting the "resource" (unwrapping+decryption of a key I'm providing).
Perhaps that is a good reason for making this its own plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no laws against it, but it's not totally ideal. This would fit better in another plugin. We do support query strings in the request. Any chance you could put the public key in there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, that could be done. I'd actually probably prefer that too, as it basically removes the need for the
kbs-types
PR I previously mentioned.