Name change first steps #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't make any changes, just saved it from Inkscape. Inkscape formats the svg different to the original Illustrator svg file, and I guess it adds some specific metadata so that's what the diff is here. I'm making this change first in its own commit so subsequent changes have (in theory at least) more useful diffs.
Tweak the shape of the half background fill to remove little gaps between it and the stroke edge of the main shape. Also move it a couple of pixels left so it's more centered. I did it manually for all three shapes, so they're likely not all entirely identical now. It would be better if they were identical, but given my lack of Inkscape experience, I think this is fine.
Not sure if this is a final draft of placeholder. I learned some new tricks in Inkscape while working on this, but (disclaimer) IANA graphic artist. In Inkscape: - Picked a font that I thought looked okay and created the text - Split up the text and did some hand kerning on the text - Added a white background instead of transparent so the same logo can be used on a light or dark background. - Exported some png files In Gimp: - Resized the canvas on the exported pngs to make a square To do the kerning I needed to tweak the inner circles of the "o" and "a" chars to avoid those letters appearing solid. At first I tried moving the layers up and down, which worked, but didn't provide the right transparency values when exporting. I ending up using path difference to combine them into a single path for the letter. Ref: https://issues.redhat.com/browse/EC-1073
Change the name in a few places and update the main logo. Note: I had some trouble exporting an svg from Inkscape, so decided to switch to a png for the home page logo.
simonbaird
force-pushed
the
name-change-first-steps
branch
from
4e84d86 to
c8e0ec6
Compare
|
🚀 Preview is available at https://0c429a01.enterprise-contract.pages.dev |
|
🚀 Preview is available at https://28fe1044.enterprise-contract.pages.dev |
simonbaird
force-pushed
the
name-change-first-steps
branch
from
c8e0ec6 to
46f3968
Compare
|
🚀 Preview is available at https://dba439c2.enterprise-contract.pages.dev |
joejstuart
approved these changes
Jan 21, 2025
I'm setting up a new CloudFlare account and a new token and trying to get the pre-merge preview working with wrangler. I set the var at the org level to "conforma" in the new org and "enterprise-contract" in the existing org. What I did to set up the Cloudflare account and token: * Sign up via https://pages.cloudflare.com/ * Create a token. Use the permissions preset as suggested at cloudflare/wrangler-action#233 * Create a GitHub org secret for it called CLOUDFLARE_API_TOKEN at the org level, (but limited it to just this repo). * Create a "pages" project in Cloudflare by clicking "+ Add", then "Pages". Name it "conforma", then set a org var called CLOUDFLARE_PROJECT_NAME, also limited to just this repo.
simonbaird
force-pushed
the
name-change-first-steps
branch
from
46f3968 to
a37ba33
Compare
|
🚀 Preview is available at https://3200b2c8.enterprise-contract.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: EC-1080