Extend 'Client' class with 'create_multiple' and 'bulk_delete' methods #38

karolkulesza · 2016-02-19T14:22:24Z

No description provided.

…oad (extended 'MessageBuilder' with 'create_multiple_request' and created 'ExecuteMultipleResult' class);

…lete’ method (accepting ‘criteria’ array);

…y forcing bundler gem update (ref: travis-ci/travis-ci#3531);

…t for the finish of bulk job execution (‘check_job_status’ helper method introduced);

…ation Improve region determination

jheth · 2016-02-24T01:12:45Z

.travis.yml

@@ -7,3 +7,5 @@ notifications:
      - [email protected]
    on_success: never
    on_failure: always
+before_install:
+  - gem install bundler


Why was this necessary?

Build on Travis CI did not succeed, due to:

"In short, the bundler version that Travis uses is very outdated. Running a gem update and install for bundler as a prestep for the Travis build fixes it usually."

Please refer to the issues described here:

NoMethodError: undefined method `spec' for nil:NilClass rubygems/rubygems#1419

Update bundler before bundle install in travis ci builds thoughtbot/factory_bot#846

Bundler that comes with Ruby 2.1.2 is too old (1.6.5) travis-ci/travis-ci#3531

jheth · 2016-02-24T01:16:37Z

@karolkulesza Thank you for the contribution. I've posted a couple comments.

jheth · 2016-02-24T14:24:02Z

@karolkulesza Thanks for the information. Could you provide some level of spec coverage to go with this change?

@call

…arties on create This allows a user to create entities like: from1 = DynamicsCRM::XML::Entity.new('activityparty') from1.attributes = DynamicsCRM::XML::Attributes.new({partyid: DynamicsCRM::XML::EntityReference.new("systemuser", @employee.id)}) to1 = DynamicsCRM::XML::Entity.new('activityparty') to1.attributes = DynamicsCRM::XML::Attributes.new({partyid: DynamicsCRM::XML::EntityReference.new("lead", @lead.id) }) body = { subject: "Subject for your phonecall", description: "Description", from: [from1], to: [to1] } @call = @client.create('phonecall', body)

Support ArrayOfEntity so one can create bound entities like ActivityParties on create

jheth · 2016-04-14T17:53:37Z

@karolkulesza Could you rebase this branch? I think it will fix the build issue. Also, I'd like to see a spec added for this.

Add special case for nil value

…ttributes in DynamicsCRM::Client;

jheth · 2016-07-25T22:19:40Z

@karolkulesza Could you rebase this branch? I think it will fix the build issue.

…Fault for 'ExecuteMultipleResponseItem');

…oad (extended 'MessageBuilder' with 'create_multiple_request' and created 'ExecuteMultipleResult' class);

…lete’ method (accepting ‘criteria’ array);

…y forcing bundler gem update (ref: travis-ci/travis-ci#3531);

…t for the finish of bulk job execution (‘check_job_status’ helper method introduced);

…ttributes in DynamicsCRM::Client;

…Fault for 'ExecuteMultipleResponseItem');

…ext";

karolkulesza · 2016-07-27T09:45:52Z

Fixed my build issues. Seems like the only one left is related with 'On Premise authentication':

  1) DynamicsCRM::Client#authenticate On-Premise authenticates with username and password
     Failure/Error: wsdl = open(organization_endpoint + "?wsdl=wsdl0").read

     SocketError:
       getaddrinfo: Name or service not known
     # ./lib/dynamics_crm/client.rb:345:in `organization_wsdl'

…oad (extended 'MessageBuilder' with 'update_multiple_request');

… method;

…ete (extended 'MessageBuilder' with 'delete_multiple_request');

…Target'" in case of multiple delete request;

jheth · 2016-09-22T20:01:23Z

@karolkulesza I'd like to see this work get contributed, but your branch is quite diverged at this point. Can you rebrase this branch from the latest master so we can see the actual differences?

jheth · 2016-11-05T14:17:53Z

@karolkulesza Would you be able to re-base your branch? I'd like to get this feature added.

Lucas Krämer de Sousa and others added 9 commits February 11, 2016 19:47

Improve define_region method

bc8d1ba

Create specs

2c73b31

Update version

ea4a242

- Extended 'Client' class with 'create_multiple' method, for bulk upl…

cc4b4fe

…oad (extended 'MessageBuilder' with 'create_multiple_request' and created 'ExecuteMultipleResult' class);

- Extended ‘client.rb’ in forked ‘dynamics_crm' gem with the ‘bulk_de…

9f7b98b

…lete’ method (accepting ‘criteria’ array);

- Fixed Travis CI issue: "undefined method `spec' for nil:NilClass” b…

bad527f

…y forcing bundler gem update (ref: travis-ci/travis-ci#3531);

- Extended ‘bulk_delete’ method in ‘client.rb’ with the option to wai…

8500100

…t for the finish of bulk job execution (‘check_job_status’ helper method introduced);

Widen curb and mimemagic dependencies.

a71ef9c

Merge pull request congaengr#37 from lucaskds/improve-region-determin…

4aba80f

…ation Improve region determination

jheth reviewed Feb 24, 2016
View reviewed changes

karolkulesza and others added 2 commits February 24, 2016 10:36

- Trivial refactoring in 'bulk_delete' method, in 'client.rb';

d3f03ad

Switch region hash to string keys.

27d9322

jheth and others added 10 commits February 24, 2016 09:48

Updated rspec syntax using transpec.

8ab364a

Widen development dependencies and update ruby versions.

1a36004

Fix be_truthy error.

97312c7

Remove ruby 2.2 for now.

1c777b3

Update to version 0.7.0 with CHANGELOG.

dea77f6

Add max dependency

9c0904d

Avoid escaping nil values.

e43c926

Test added

d98a567

Merge pull request congaengr#41 from mbhnyc/master

f9a9a4d

Support ArrayOfEntity so one can create bound entities like ActivityParties on create

stephanvd and others added 3 commits April 20, 2016 16:18

Add special case for nil value

81cbb31

Merge pull request congaengr#43 from stephanvd/feature/support-nil

7faad5f

Add special case for nil value

- Exposed 'security_token0', 'security_token1' and 'key_identifier' a…

5f6f6ef

…ttributes in DynamicsCRM::Client;

karolkulesza added 10 commits July 26, 2016 17:22

- Extended 'Fault' support to handle different format (as in case of …

5609ad9

…Fault for 'ExecuteMultipleResponseItem');

- Extended 'Client' class with 'create_multiple' method, for bulk upl…

dc1b0a0

…oad (extended 'MessageBuilder' with 'create_multiple_request' and created 'ExecuteMultipleResult' class);

- Extended ‘client.rb’ in forked ‘dynamics_crm' gem with the ‘bulk_de…

46635e8

…lete’ method (accepting ‘criteria’ array);

- Fixed Travis CI issue: "undefined method `spec' for nil:NilClass” b…

936bef6

…y forcing bundler gem update (ref: travis-ci/travis-ci#3531);

- Extended ‘bulk_delete’ method in ‘client.rb’ with the option to wai…

4a17009

…t for the finish of bulk job execution (‘check_job_status’ helper method introduced);

- Trivial refactoring in 'bulk_delete' method, in 'client.rb';

8122975

- Exposed 'security_token0', 'security_token1' and 'key_identifier' a…

d13e1db

…ttributes in DynamicsCRM::Client;

- Extended 'Fault' support to handle different format (as in case of …

ca71d21

…Fault for 'ExecuteMultipleResponseItem');

Merge branch 'master' of https://github.com/karolkulesza/dynamics_crm

b50884b

- Fixed the issue: "undefined method `blank?' for "S:Sender":REXML::T…

89622e5

…ext";

karolkulesza added 4 commits July 27, 2016 15:52

- Extended 'Client' class with 'update_multiple' method, for bulk upl…

ca70a08

…oad (extended 'MessageBuilder' with 'update_multiple_request');

- 'MessageBuilder' refactoring: Introduced 'execute_multiple_request'…

d2ce044

… method;

- Extended 'Client' class with 'delete_multiple' method, for bulk del…

d98e0ec

…ete (extended 'MessageBuilder' with 'delete_multiple_request');

- Fixed the issue: "Required member 'LogicalName' missing for field '…

2ac9f77

…Target'" in case of multiple delete request;

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend 'Client' class with 'create_multiple' and 'bulk_delete' methods #38

Extend 'Client' class with 'create_multiple' and 'bulk_delete' methods #38

karolkulesza commented Feb 19, 2016

jheth Feb 24, 2016

karolkulesza Feb 24, 2016

jheth commented Feb 24, 2016

jheth commented Feb 24, 2016

jheth commented Apr 14, 2016

jheth commented Jul 25, 2016

karolkulesza commented Jul 27, 2016

jheth commented Sep 22, 2016

jheth commented Nov 5, 2016

Extend 'Client' class with 'create_multiple' and 'bulk_delete' methods #38

Are you sure you want to change the base?

Extend 'Client' class with 'create_multiple' and 'bulk_delete' methods #38

Conversation

karolkulesza commented Feb 19, 2016

jheth Feb 24, 2016

Choose a reason for hiding this comment

karolkulesza Feb 24, 2016

Choose a reason for hiding this comment

jheth commented Feb 24, 2016

jheth commented Feb 24, 2016

jheth commented Apr 14, 2016

jheth commented Jul 25, 2016

karolkulesza commented Jul 27, 2016

jheth commented Sep 22, 2016

jheth commented Nov 5, 2016