Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMD healthchecks running with /bin/sh #1106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ben-krieger
Copy link

@ben-krieger ben-krieger commented Jan 13, 2025

Fixes #23

This change causes ["CMD", "exe", "arg1", "arg2"] style healthchecks to run using the given command directly and NOT using /bin/sh -c.

This is compatible with Podman 1.5.0 and later.

  • Unit tests
  • Release note

@p12tic
Copy link
Collaborator

p12tic commented Jan 13, 2025

Thanks for the PR. It looks good. Please add unit test for container_to_args here and a release note to the newsfragments directory (you can look here for inspiration on how release note looks like).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WIP: proper healthchecks support
2 participants