Add --no-trunc to artifact ls

[baude]

added a --no-trunc flag to artifact ls, which follows what images has done. by default now, the ls output will have the shortened 12 character digest. the --no-trunc will output the full digest.

Does this PR introduce a user-facing change?

Added `no-trunc` option to artifact ls and shortened digests in default ls output to 12 characters.

[baude]

im going to add some tests here still

[baude]

ok, tests added

[Luap99]

Not sure why we would need to define a extra function here.

if !listFlag.noTrunc {
	artifactHash = artifactHash[0:12]
}

This would do the same thing without an extra function call.

[baude]

i meant to delete line 101.

[baude]

reverted ... i felt funny about the fact that having a conditional check on something that was by default ... but i inverted the logic a tad, see how you like it.

[Luap99]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

I want to cherry-pick this into 5.4 if nobody minds. Technically a feature but small enough that I think it makes sense to make the change as early as possible and not have people live with a slightly different format until 5.5 comes out

[mheon]

LGTM but needs a rebase

[mheon]

/lgtm

[mheon]

/cherry-pick v5.4
We can discuss if we want this in the cherry-pick PR

[openshift-cherrypick-robot]

@mheon: once the present PR merges, I will cherry-pick it on top of v5.4 in a new PR and assign it to you.

In response to this:

/cherry-pick v5.4
We can discuss if we want this in the cherry-pick PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@mheon: #25182 failed to apply on top of branch "v5.4":

Applying: Add --no-trunc to artifact ls
Using index info to reconstruct a base tree...
M	docs/source/markdown/.gitignore
M	test/e2e/artifact_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/artifact_test.go
Auto-merging docs/source/markdown/.gitignore
CONFLICT (content): Merge conflict in docs/source/markdown/.gitignore
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Add --no-trunc to artifact ls

In response to this:

/cherry-pick v5.4
We can discuss if we want this in the cherry-pick PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.