-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There's a comma in the list of files in install.sh #739
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request removes an extraneous comma from the list of files in install.sh and removes the -qq flag from apt-get commands to provide more verbose output during installation. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericcurtin - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
086005a
to
7194bcd
Compare
It shouldn't be there. Also remove the -qq, it makes it feel like the script isn't making progress as podman takes a while to install. Signed-off-by: Eric Curtin <[email protected]>
7194bcd
to
d792b45
Compare
It shouldn't be there. Also remove the -qq, it makes it feel like the script isn't making progress as podman takes a while to install.
Summary by Sourcery
Remove the -qq flag from apt-get to show installation progress and fix a syntax error in a list of files.
Bug Fixes:
-qq
flag fromapt-get
to make the installation progress visible.Chores: