-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to "Hugo Relearn" theme #1501
base: main
Are you sure you want to change the base?
Conversation
This is now ready for review. Note: this is not a 1:1 restoration of how the docs previously looked. I deliberately only adjusted a few things from the new default theme of the new Hugo Theme, so that we can simply rely on the state of the original Theme more again. |
Btw. if you are checking this out in a local repository that you had already cloned previously: switching the Git submodule is a little finicky. Something like this should work:
Though this leaves the content of the original submodule present and it will be marked as an uncommitted change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through a lot of pages on this version (dark mode toggle is in the sidebar anyways <3) and didn't see anything that would bother me.
I do like the new main column header from the relearn as it's not just floating anywhere.
We could improve on --INTERNAL-MAIN-BG-color
as that one overwrites the normal body color - without it, it would be the same color as it is right now... but that can be fixed in a follow-up-pr imo
(And if
- the code blocks (diamond background pattern with the border)
or anything need changes,
that can be done in a follow-up PR <3
Do you mean the background color of the dark mode?
What diamond background pattern do you mean? |
Of the content in darkmode, yes. The color seems off
The second border of the code block in the old docs to make it more visible |
Ah yes, that is something that I actually wanted to port over from the old theme as well.
Yes, but that was just the style of the original Hugo Learn theme. It was not an addition done by ourselves. I would rather keep the style of the Hugo Relearn theme. Hugo Relearn also uses Hugo's native code highlighting and not Highlight.js anymore. This is why there is now also a compeletely new color scheme for the code - I chose |
Implements #1462