feat: strip protocol from host if provided during upload [EXT-00] #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjolton-contentful
force-pushed
the
feat/strip-host-protocol-during-upload
branch
3 times, most recently
from
43b52af to
24f5920
Compare
jjolton-contentful
force-pushed
the
feat/strip-host-protocol-during-upload
branch
from
24f5920 to
62a4d15
Compare
t-col
reviewed
Sep 30, 2024
| @@ -55,3 +56,7 @@ export async function buildAppUploadSettings(options: UploadOptions): Promise<Up | |||
| ...appInfo, | |||
| }; | |||
| } | |||
|
|
|||
| export function hostProtocolFilter (input: string) { | |||
| return input.replace(/^https?:\/\//, ''); | |||
There was a problem hiding this comment.
does this catch http:// as well?
There was a problem hiding this comment.
It does indeed but I probably should have added a test case for http too huh
Welcome to Node.js v20.17.0.
Type ".help" for more information.
> "http://api.contentful.com".replace(/^https?:\/\//, '')
'api.contentful.com'
> "https://api.contentful.com".replace(/^https?:\/\//, '')
'api.contentful.com'
There was a problem hiding this comment.
added in 483466d
t-col
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where specifying a host that starts with http:// or https:// causes the upload process to break.
To fix this, an inquirer filter function has been added to the host prompt in
buildAppUploadSettings. This function strips out any leading http:// or https:// from the user's input, ensuring that only the base URL is used.