fix(preview): detect and handle circular dependencies [SPA-2511] #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Chaoste
force-pushed
the
fix/SPA-2511-circular-dep-preview
branch
from
97f071d to
ecef010
Compare
Chaoste
force-pushed
the
fix/SPA-2511-circular-dep-preview
branch
from
f399e4a to
05762a7
Compare
anwaar931
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When there is a circular reference among used patterns, the fetchers and the renderer will fail with a "Maximum call stack size exceeded".
Approach
To handle this properly, we have to pass down the parent patterns. If a pattern appears that is already part of that set, we bail to avoid an infinite loop.