-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Growthbook App #3615
feat: Add Growthbook App #3615
Conversation
There is a failing test. Looks like we need to add a mock API key to the test and/or null check in the obfuscateApiKey method. |
|
5179003
to
6fa0291
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission! This is looking pretty good, just have a few questions for you about the app:
- To run this locally, you are using
dev
? I tried using thestart
command, but it didn't appear to work in an expected way and couldn't find any specific instructions. Thedev
command did seem to work wrt sourcing the app locally on port 3000. - Curious if you were able to get a hosted bundle built with your
build
command to work. https://www.contentful.com/developers/docs/extensibility/app-framework/app-bundle/ Eventually this app will need to work as a hosted bundle, and I've been having problems getting this working with this app, but I could also be missing a step in your workflow.
Thanks for the help!
Thanks for taking a look. Yes when I run
I've been able to deploy it running |
Perfect, thanks for the fixes and response. I took another look and identified the reason why we weren't able serve the statically hosted files. Let me know if that looks good to you and commit it if so. After that we're ready to accept this PR and we'll get underway on the deployment process on our end |
bf679be
to
7f06f35
Compare
c7d5431
to
a560709
Compare
@tzjames thanks for making the requested change. We'll start the process of deploying the app today. |
That's great news. Let me know when it's deployed and we will land our docs change and example app. |
@tzjames it's out now, please let us know if you see any issues or problems with it working. It looked fine on our end, but we don't have a valid api key for growthbook so we can't really end-to-end test it. Thanks again for the submission and your assistance with the process! |
@mgoudy91 Looks good. It seems to be working. |
Purpose
Growthbook is the #1 open-source & warehouse native experimentation platform. This app lets Contentful customers create new experiments directly within Contentful and manage which content will be shown to the experiment's users.
Approach
The app consists of a library to connect to the Growthbook API. It is installed in three locations:
Users of this app will have to install the Growthbook SDK on their site. The Growthbook SDK will figure out which variation index to show to which users. Showing the correct content to the users for the Growthbook Experiment content type is as simple as selecting that same index in the variations list and looking up the content it references.
Testing steps
An example app lays out the steps to integrate the Growthbook Contentful app to create a working site.
growthbook/examples#52
ji/contentful
branch.Run
npm run tests
Breaking Changes
No it should not affect other apps.
Dependencies and/or References
The example app will be landed once this app is approved and on the marketplace.
The wiki page will also be published on Growthbook Docs.
Deployment
The app can be installed by running
npm run dev
and installing a custom app on Contentful pointing to localhost:3000.