refactor(pattern): remove fixme regarding use_frequency and add code ref

conveyal · Jan 28, 2019 · 3b3b4f4 · evansiroky · Jan 30, 2019 · 3b3b4f4
1 parent 4e615d7
commit 3b3b4f4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -8,7 +8,7 @@
 
   <groupId>com.conveyal</groupId>
   <artifactId>gtfs-lib</artifactId>
-  <version>4.2.5-SNAPSHOT</version>
+  <version>4.8</version>
   <packaging>jar</packaging>
 
   <licenses>

diff --git a/src/main/java/com/conveyal/gtfs/model/Pattern.java b/src/main/java/com/conveyal/gtfs/model/Pattern.java
@@ -115,8 +115,9 @@ public void setStatementParameters(PreparedStatement statement, boolean setDefau
         statement.setString(oneBasedIndex++, name);
         // Editor-specific fields
         setIntParameter(statement, oneBasedIndex++, direction_id);
-        // FIXME: use_frequency should be based on whether the trip is associated with frequency entries.
-        setIntParameter(statement, oneBasedIndex++, 0); // use_frequency
+        // Note: pattern#use_frequency is set in JdbcGtfsSnapshotter here:
+        // https://github.com/conveyal/gtfs-lib/blob/0c6aca98a83d534853b74011e6cc7bf376592581/src/main/java/com/conveyal/gtfs/loader/JdbcGtfsSnapshotter.java#L196-L211
+        setIntParameter(statement, oneBasedIndex++, INT_MISSING); // use_frequency
         // FIXME: Shape set might be null?
         statement.setString(oneBasedIndex++, associatedShapes.iterator().next());
     }