Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov.io reports not being uploaded for all commits in master branch #193

Closed
evansiroky opened this issue Feb 11, 2019 · 1 comment · Fixed by #196
Closed

Codecov.io reports not being uploaded for all commits in master branch #193

evansiroky opened this issue Feb 11, 2019 · 1 comment · Fixed by #196
Assignees
Labels

Comments

@evansiroky
Copy link
Contributor

Observed behavior

The commits generated by maven-semantic-release intentionally make commits that skip CI runs. Codecov seems to be looking at the commit as noted in the Travis environment variables (see this Travis build). Therefore, it only uploads a report for the commit that is a merge to master, not the release commit or post-release commit. The end result is that in the next PR made to master, a record of the last coverage report on master does not exist (#192 (comment)).

Expected behavior

Code coverage reports should be generated and uploaded for each commit to master.

Steps to reproduce the problem

Make a PR to merge to master.

Any special notes on configuration used

N/A

Version of datatools-server and datatools-ui if applicable (exact commit hash or branch name)

master branch

@landonreed
Copy link
Contributor

🎉 This issue has been resolved in version 4.2.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants