Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix Release #192

Merged
merged 20 commits into from
Feb 13, 2019
Merged

Bug Fix Release #192

merged 20 commits into from
Feb 13, 2019

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Feb 11, 2019

Once #190 is merged (it is merged!), I would like to create a new bug fix release.

Issues fixed

#192
#189
#170
#186
#187

@landonreed landonreed added the WIP Work in progress label Feb 11, 2019
@landonreed landonreed self-assigned this Feb 11, 2019
@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #192 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #192      +/-   ##
===========================================
- Coverage     57.59%   57.5%   -0.09%     
+ Complexity      831     800      -31     
===========================================
  Files           144     144              
  Lines          7602    7314     -288     
  Branches        959     850     -109     
===========================================
- Hits           4378    4206     -172     
+ Misses         2867    2769      -98     
+ Partials        357     339      -18
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/conveyal/gtfs/model/Pattern.java 73.33% <100%> (ø) 4 <1> (ø) ⬇️
...ava/com/conveyal/gtfs/loader/JdbcGtfsExporter.java 83.43% <100%> (ø) 23 <0> (ø) ⬇️
...om/conveyal/gtfs/graphql/fetchers/JDBCFetcher.java 56.83% <100%> (ø) 25 <0> (ø) ⬇️
...java/com/conveyal/gtfs/loader/JdbcTableWriter.java 54.67% <100%> (-1.62%) 96 <23> (-31)
...a/com/conveyal/gtfs/graphql/GraphQLGtfsSchema.java 98.25% <100%> (ø) 1 <0> (ø) ⬇️
...om/conveyal/gtfs/graphql/fetchers/FeedFetcher.java 79.16% <100%> (ø) 4 <0> (ø) ⬇️
...onveyal/gtfs/validator/PatternFinderValidator.java 88.69% <100%> (ø) 9 <0> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1d41d8...658e115. Read the comment docs.

Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until #193 is resolved.

@evansiroky
Copy link
Contributor

Fix for #193 is here: #196.

@landonreed landonreed assigned evansiroky and unassigned landonreed Feb 13, 2019
@landonreed landonreed removed the WIP Work in progress label Feb 13, 2019
@evansiroky evansiroky assigned landonreed and unassigned evansiroky Feb 13, 2019
@landonreed landonreed merged commit b14015c into master Feb 13, 2019
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 4.2.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants