-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds open source licenses (fixes #2941) #3982
Open
alexzvk
wants to merge
31
commits into
cookiecutter:master
Choose a base branch
from
alexzvk:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ictionary in update_licenses.py and post_gen_proj.py to reduce time complexity
2 tasks
🐌any timeline for when this would get merged? |
No |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My EECS 481 final project. Takes the pull request from @Andrew-Chen-Wang (who I have been in contact with) that fixes #2941 and implements suggestions on said pull request.
Note that the build works locally for me, but I was not able to pass all of the automated checks. While there remains much I want to work on... the end of the semester looms and I must make a pull request to receive credit.
Checklist:
In line with the previous pull request: not sure if it's worth putting all of the licenses in the documentation.
Rationale
Fixes #2941
Makes it easier to maintain having many options for open-source licenses since a script can be run that pulls them all from a maintained github repository