Skip to content

Commit

Permalink
[fixes] add missing "to" in no_membership_warning email and send emai…
Browse files Browse the repository at this point in the history
…l only once
  • Loading branch information
markets committed Feb 1, 2025
1 parent 17904b2 commit d645c48
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/jobs/membership_warning_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ class MembershipWarningJob < ActiveJob::Base

def perform
User.without_memberships.find_each do |user|
if user.created_at < 15.days.ago && user.no_membership_warning?
if user.created_at.to_date == 15.days.ago.to_date && user.no_membership_warning?
OrganizationNotifier.no_membership_warning(user).deliver_now
end
end
Expand Down
1 change: 1 addition & 0 deletions app/mailers/organization_notifier.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def no_membership_warning(user)
I18n.with_locale(user.locale) do
mail(
subject: "Do not forget to join a Timebank",
to: user.email
)
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/jobs/membership_warning_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
let!(:user) { Fabricate(:user) }
let!(:member) { Fabricate(:member, organization: org, user: user) }
let!(:user_with_no_memberships) { Fabricate(:user) }
let!(:user_with_no_memberships2) { Fabricate(:user, created_at: 16.days.ago) }
let!(:user_with_no_memberships2) { Fabricate(:user, created_at: 15.days.ago) }

describe '#perform' do
it "should send emails in user's locale" do
Expand Down

0 comments on commit d645c48

Please sign in to comment.