Adapt to https://github.com/math-comp/math-comp/pull/1046 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
CohenCyril
reviewed
Nov 30, 2023
Comment on lines
-121
to
+125
| HB.instance Definition _ (R : dvdRingType) := Ring_hasDiv.Build {poly R} | ||
| Definition poly_of (R : semiRingType) := {poly R}. | ||
|
|
||
| HB.instance Definition _ (R : dvdRingType) := | ||
| GRing.IntegralDomain.on (poly_of R). | ||
| HB.instance Definition _ (R : dvdRingType) := Ring_hasDiv.Build (poly_of R) |
There was a problem hiding this comment.
@proux01 I do not understand what happens here...
There was a problem hiding this comment.
IIRC, the dvdRing instance was created on poly_of (with phantom) so there was no instance on polynomial (without phantom). This was important because later in that polydvd.v file, another factory creates a conflicting instance of dvdRing on polynomial.
So I just reproduced the previous hack but, IMHO, the correct fix would be to integrate dvdRing in between unitRing and Field in ssralg.v.
proux01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to math-comp/math-comp#1046