Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/rejection-reason-models #4382

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

marcushaddon
Copy link
Contributor

What does this PR do?

This PR brings in the backend models related to rejection reasons, so that any other work that needs to reference them may do so.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

New types RejectionReason, REJECTION_REASON_CODE, CommentRejectionReasonInput were created. The model for CommentModerationAction was updated to include an optional field for reason.

Does this PR introduce any new environment variables or feature flags?

No.

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

npm test and npm run watch.

Where any tests migrated to React Testing Library?

No.

How do we deploy this PR?

No special considerations needed.

Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just found 3 typos you likely want to fix before merging. Approving though, so you can fix the typo and just carry on getting this into the dsa epic branch!

"""
detailedExplaination is any additional information the user wishes to provide.
"""
detailedExplaination: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: detailedExplaination -> detailedExplanation

"""
detailedExplaination is any additional information the user wishes to provide.
"""
detailedExplaination: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here as well

rejectionReason?: {
reason: GQLREJECTION_REASON_CODE;
legalGrounds?: string;
detailedExplaination?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Marcus! Looks good

@kabeaty kabeaty merged commit 1c62aed into feat/dsa-launch-pad Oct 30, 2023
@kabeaty kabeaty deleted the feat/rejection-reason-models branch October 30, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants