Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-17816 contract verifying notary APIs #1372

Merged
merged 16 commits into from
Dec 14, 2023
Merged

CORE-17816 contract verifying notary APIs #1372

merged 16 commits into from
Dec 14, 2023

Conversation

jennyang-r3
Copy link
Contributor

No description provided.

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 30, 2023 •
edited
Loading

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 30, 2023 •
edited
Loading

Jenkins build for PR 1372 build 24

Build Successful:
Jar artifact version produced by this PR: 5.2.0.13-alpha-1702548588672

@jennyang-r3 jennyang-r3 marked this pull request as ready for review November 30, 2023 14:28
@jennyang-r3 jennyang-r3 requested a review from a team as a code owner November 30, 2023 14:28
blsemo
blsemo previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennyang-r3 jennyang-r3 force-pushed the jennyang/CORE-17816-contractverifying-notary branch 2 times, most recently from edcf164 to 3452906 Compare December 1, 2023 17:26
@jennyang-r3 jennyang-r3 force-pushed the jennyang/CORE-17816-contractverifying-notary branch from 4693c13 to 1a623e6 Compare December 4, 2023 10:30
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 4, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1372/6/ has failed for PR 1372 build 6

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 4, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1372/6/ has failed for PR 1372 build 6

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

blsemo
blsemo previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkovacsx nkovacsx self-requested a review December 7, 2023 13:17
@jennyang-r3 jennyang-r3 force-pushed the jennyang/CORE-17816-contractverifying-notary branch from 7d40ea5 to 15aabc2 Compare December 8, 2023 09:51
@jennyang-r3 jennyang-r3 force-pushed the jennyang/CORE-17816-contractverifying-notary branch 2 times, most recently from 8967881 to aba115d Compare December 11, 2023 15:00
@jennyang-r3 jennyang-r3 force-pushed the jennyang/CORE-17816-contractverifying-notary branch from 1259cf3 to 566c516 Compare December 12, 2023 10:56
blsemo
blsemo previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennyang-r3 jennyang-r3 force-pushed the jennyang/CORE-17816-contractverifying-notary branch from 907ebe2 to 748368d Compare December 14, 2023 09:53
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

blsemo
blsemo approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennyang-r3 jennyang-r3 merged commit 52dc74e into release/os/5.2 Dec 14, 2023
3 checks passed
@jennyang-r3 jennyang-r3 deleted the jennyang/CORE-17816-contractverifying-notary branch December 14, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlajos vlajos vlajos left review comments

@nkovacsx nkovacsx nkovacsx left review comments

@blsemo blsemo blsemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jennyang-r3 @blsemo @vlajos @nkovacsx