Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-18821 default corda.notary.service.backchain.required to true #1391

Merged

Conversation

nkovacsx
Copy link
Contributor

@nkovacsx nkovacsx commented Dec 11, 2023

Set a default value for corda.notary.service.backchain.required if not provided.

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 11, 2023

Jenkins build for PR 1391 build 5

Build Successful:
Jar artifact version produced by this PR: 5.2.0.15-alpha-1702561834794

…nto nandor/CORE-18821/make-backchain-field-optional
…nto nandor/CORE-18821/make-backchain-field-optional
@nkovacsx nkovacsx marked this pull request as ready for review December 12, 2023 14:10
@nkovacsx nkovacsx requested a review from a team as a code owner December 12, 2023 14:10
@nkovacsx nkovacsx requested review from a team December 12, 2023 14:11
williamvigorr3
williamvigorr3 previously approved these changes Dec 12, 2023
Copy link
Contributor

@williamvigorr3 williamvigorr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Network Team Code

blsemo
blsemo previously approved these changes Dec 12, 2023
Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…nto nandor/CORE-18821/make-backchain-field-optional

# Conflicts:
#	gradle.properties
@nkovacsx nkovacsx dismissed stale reviews from blsemo and williamvigorr3 via 2cc583c December 14, 2023 13:50
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved version change.

@nkovacsx nkovacsx merged commit 26b439d into release/os/5.2 Dec 14, 2023
2 checks passed
@nkovacsx nkovacsx deleted the nandor/CORE-18821/make-backchain-field-optional branch December 14, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants