-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-18548: Add link manager boot configuration path #1393
CORE-18548: Add link manager boot configuration path #1393
Conversation
Jenkins build for PR 1393 build 2 Build Successful: |
Scanning for breaking API changes introduced by this PR Scan Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gradle.properties
Outdated
@@ -5,7 +5,7 @@ cordaProductVersion = 5.2.0 | |||
# NOTE: update this each time this module contains a breaking change | |||
## NOTE: currently this is a top level revision, so all API versions will line up, but this could be moved to | |||
## a per module property in which case module versions can change independently. | |||
cordaApiRevision = 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure this is a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-run-http-client # Conflicts: # gradle.properties
43816f8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See runtime pull request in corda/corda-runtime-os#5235