Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-18548: Add link manager boot configuration path #1393

Merged

Conversation

yift-r3
Copy link
Contributor

@yift-r3 yift-r3 commented Dec 12, 2023

See runtime pull request in corda/corda-runtime-os#5235

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 12, 2023

Jenkins build for PR 1393 build 2

Build Successful:
Jar artifact version produced by this PR: 5.2.0.14-alpha-1702553175088

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@yift-r3 yift-r3 marked this pull request as ready for review December 12, 2023 16:09
@yift-r3 yift-r3 requested a review from a team as a code owner December 12, 2023 16:09
@yift-r3 yift-r3 requested a review from a team December 12, 2023 16:09
williamvigorr3
williamvigorr3 previously approved these changes Dec 12, 2023
Copy link
Contributor

@williamvigorr3 williamvigorr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -5,7 +5,7 @@ cordaProductVersion = 5.2.0
# NOTE: update this each time this module contains a breaking change
## NOTE: currently this is a top level revision, so all API versions will line up, but this could be moved to
## a per module property in which case module versions can change independently.
cordaApiRevision = 12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this is a breaking change?

@vkolomeyko vkolomeyko self-requested a review December 12, 2023 17:08
vkolomeyko
vkolomeyko previously approved these changes Dec 12, 2023
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yift-r3 yift-r3 dismissed stale reviews from vkolomeyko and williamvigorr3 via 43816f8 December 14, 2023 11:25
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@williamvigorr3 williamvigorr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yift-r3 yift-r3 merged commit 32846c8 into release/os/5.2 Dec 14, 2023
2 checks passed
@yift-r3 yift-r3 deleted the yift/core-18548/prepare-gateway-to-run-http-client branch December 14, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants