fix(icon-view): do not show a broken image (#1399)

* fix(icon-view): do not show a broken image * Create funny-kangaroos-hammer.md
core-ds · Oct 11, 2024 · 161ad6b · 161ad6b
1 parent 290acf4
commit 161ad6b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.changeset/funny-kangaroos-hammer.md b/.changeset/funny-kangaroos-hammer.md
@@ -0,0 +1,5 @@
+---
+"@alfalab/core-components-icon-view": patch
+---
+
+Изменена логика отрисовки image тэга - теперь image рендерится всегда и скрывается только в случае ошибки загрузки
diff --git a/packages/icon-view/src/components/base-shape/component.tsx b/packages/icon-view/src/components/base-shape/component.tsx
@@ -124,7 +124,6 @@ export const BaseShape = forwardRef<HTMLDivElement, BaseShapeProps>(
     ) => {
         const [width, height] = typeof size === 'object' ? [size.width, size.height] : [size, size];
         const imageLoadingState = useImageLoadingState({ src: imageUrl || '' });
-        const loadedUrl = imageLoadingState === 'loaded' ? imageUrl : undefined;
 
         const imagePatternId = useId();
 
@@ -174,12 +173,12 @@ export const BaseShape = forwardRef<HTMLDivElement, BaseShapeProps>(
                             d={shapeDPath}
                         />
 
-                        {loadedUrl && (
+                        {imageUrl && imageLoadingState !== 'error' && (
                             <Fragment>
                                 <defs>
                                     <pattern id={imagePatternId} width='100%' height='100%'>
                                         <image
-                                            href={loadedUrl}
+                                            href={imageUrl}
                                             width='100%'
                                             height='100%'
                                             preserveAspectRatio='xMidYMid slice'