feat(skeleton): new prop borderRadius #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haskiro
requested review from
reme3d2y,
fulcanellee,
SiebenSieben and
hextion
as code owners
🦋 Changeset detectedLatest commit: e188553 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 13197662521Details
💛 - Coveralls |
|
Собрана новая демка. |
fulcanellee
approved these changes
Jan 20, 2025
|
Собрана новая демка. |
packages/skeleton/src/vars.css
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| :root { | |||
| --skeleton-display: block; | |||
| --skeleton-border-radius: var(--border-radius-8); | |||
| --skeleton-border-radius: var(--border-radius-8); /* не используется в самом компоненте */ | |||
There was a problem hiding this comment.
Кто-то мог его использовать, может оставить по дефолту?
Чтобы если не указан проп borderRadius, было скругление из css переменной
There was a problem hiding this comment.
по дефолту используется именно такое значение. Если попробовать именно это название использовать, то уже не получится в css так лаконично, как сейчас. Сама переменная остается, я ее не удалял, просто это название внутри компонента не берется
reme3d2y
reviewed
Jan 29, 2025
reme3d2y
approved these changes
Jan 29, 2025
|
Собрана новая демка. |
hextion
requested changes
Jan 31, 2025
hextion
approved these changes
Feb 7, 2025
hextion
approved these changes
Feb 7, 2025
Oladii
approved these changes
Feb 7, 2025
hextion
approved these changes
Feb 7, 2025
|
Собрана новая демка. |
|
Собрана новая демка. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлен новый проп borderRadius в компонент Skeleton для указания скругления углов. Заложена возможность задания разных значений для каждого угла
ссылка на таску