-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/cmd-build: Add ostree
target
#348
Conversation
LGTM! |
I almost think this would be better served as part of the So we would default to |
Hmm yeah, I think I like that. |
I'm often just iterating on the OSTree content itself and don't require new images. In such cases, it's a waste of time to wait for images to be generated when all I want is the treecompose. But using `coreos-assembler build` is still more convenient than dropping down to `rpm-ostree compose tree`, especially with the virtualization wrapper. Change the concept of `IMAGETYPES` to `TARGETS` and add a new `ostree` target for which we only generate a commit to the OSTree repo. This is a natural extension of coreos#302. Crucially though, we still create a build directory under `builds/` with metadata about the built commit. The only practical difference is that there are no image files and no subkeys under `images` in `meta.json`. (I didn't bother breaking the idempotency coupling here wrt the kickstart since (1) it's going away, and (2) this is really just for the local dev case where you're iterating on the tools, like rpm-ostree, or the content, like the treefile.)
118792a
to
1ce670f
Compare
Done! (With the tweak that any of the image types automatically implies |
LGTM |
ostree
target
Ran an unprivileged build of RHCOS for One nit: if you run That being said, this WFM, so 👍 |
Awesome, thanks for testing! 👍
Hmm, maybe. Though that would blur the line between |
That seems like a good compromise; but let's not hold up merging this on that idea. |
I'm often just iterating on the OSTree content itself and don't require
new images. In such cases, it's a waste of time to wait for images to be
generated when all I want is the treecompose. But using
coreos-assembler build
is still more convenient than dropping down torpm-ostree compose tree
, especially with the virtualization wrapper.Add a new
--ostree-only
option in which we only generate a commit tothe OSTree repo. This is a natural extension of #302. Crucially though,
we still create a build directory under
builds/
with metadata aboutthe built commit. The only practical difference is that there are no
image files and no subkeys under
images
inmeta.json
.(I didn't bother breaking the idempotency coupling here wrt the
kickstart since (1) it's going away, and (2) this is really just for the
local dev case where you're iterating on the tools, like rpm-ostree, or
the content, like the treefile.)