qemu: Support setting up a virtio console (hvc0) #3689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main motivation here is debugging issues with podman machine on Apple Virtualization, which only implements virtio, so we need to talk to hvc0. However there's no reason for us not to also do this with qemu; we already have a few references to hvc0 in our console setup. Turning this on by default will hence require a PR to f-c-c to add that. But for now let's make it easier to test via an env var.
cgwalters
added a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Jan 3, 2024
Pairs with coreos/coreos-assembler#3689 Basically hvc0 is faster and more modern, but requires us to opt-in specifically. We already had a few usages of hvc0 from cloud providers that default to this, no reason for us not to do it for our own qemu provider. (One thing TODO here: I believe s390x qemu could do this too; as of right now we don't have any references to s390x here)
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
If someone wanted to use this without coreos/fedora-coreos-config#2785 merging they would have to make sure to have a local build |
|
Based on discussions in coreos/fedora-coreos-config#2785, let's close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation here is debugging issues with podman machine on Apple Virtualization, which only implements virtio, so we need to talk to hvc0.
However there's no reason for us not to also do this with qemu; we already have a few references to hvc0 in our console setup.
Turning this on by default will hence require a PR to f-c-c to add that.
But for now let's make it easier to test via an env var.