Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1534 Change: Allow Removal of tzdata #2550

Merged
merged 1 commit into from
Aug 16, 2023
Merged

#1534 Change: Allow Removal of tzdata #2550

merged 1 commit into from
Aug 16, 2023

Conversation

yasminvalim
Copy link
Contributor

This PR is adding the tzdata package in Fedora CoreOS. 📦


To know more about this change, please check this documentation .

@yasminvalim yasminvalim linked an issue Aug 15, 2023 that may be closed by this pull request
F39 Change: Allow Removal of tzdata coreos/fedora-coreos-tracker#1534
Closed
@dustymabe
Copy link
Member

In this case maybe let's not include a link to the issue in the comment:

  # Allow for configuring different timezones
  - tzdata

But we do want to include a link to the issue in the git message.

Also, let's put this over in system-configuration.yaml rather than here since it's not specific to Fedora CoreOS. i.e. we'll want this same thing in RHCOS too when the tzdata dep drops out there.

@dustymabe
Copy link
Member

dustymabe commented Aug 15, 2023 •
edited
Loading

Can we get the commit message updated? Something like:

manifests: name tzdata package in packages list

The tzdata package is undergoing a change [1] to allow it
to not be required by some other packages (like glibc). We
don't want the tzdata package to drop out of Fedora CoreOS
so let's name the package here in our manifest.

[1] https://fedoraproject.org/wiki/Changes/AllowRemovalOfTzdata

Closes https://github.com/coreos/fedora-coreos-tracker/issues/1534

@yasminvalim
manifests: name tzdata package in packages list
5d8949c 
The tzdata package is undergoing a change [1] to allow it
to not be required by some other packages (like glibc). We
don't want the tzdata package to drop out of Fedora CoreOS
so let's name the package here in our manifest.

[1] https://fedoraproject.org/wiki/Changes/AllowRemovalOfTzdata

Closes coreos/fedora-coreos-tracker#1534
@yasminvalim yasminvalim force-pushed the origin/1532-tzdata-package branch from 38fceda to 5d8949c Compare August 16, 2023 14:19
@yasminvalim
Copy link
Contributor Author

Done! Thanks for your review. 😊

dustymabe
dustymabe approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe enabled auto-merge (rebase) August 16, 2023 14:31
@dustymabe dustymabe merged commit d9db435 into coreos:testing-devel Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F39 Change: Allow Removal of tzdata
2 participants
@yasminvalim @dustymabe