Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

denylist: extend snoozes for kdump.crash #2689

Merged
merged 1 commit into from
Oct 25, 2023
Merged

denylist: extend snoozes for kdump.crash #2689

merged 1 commit into from
Oct 25, 2023

Conversation

gursewak1997
Copy link
Member

@gursewak1997 gursewak1997 commented Oct 24, 2023 •
edited
Loading

For rawhide ppc64le failure, we don't have a fixed kernel yet. For the aarch64 selinux failure, it's been fixed in kexec-tools 2.0.27 which is now in F39. Will remove this once the prod streams have moved to F39

@gursewak1997 gursewak1997 enabled auto-merge (rebase) October 24, 2023 23:25
@gursewak1997 gursewak1997 force-pushed the kdump-snooze-extend-ppc64le branch 2 times, most recently from 20049a9 to a234169 Compare October 25, 2023 15:48
@gursewak1997 gursewak1997 changed the title denylist: snooze kdump.crash for ppc64le in rawhide denylist: extend snoozes for kdump.crash Oct 25, 2023
@dustymabe
Copy link
Member

For rawhide, as ppc64le builds fail with latest kexec-tools-2.0.27-3.fc40 we cannot test the kdump.crash against it.

Right, the builds fail with 2.0.27-3.fc40 but we pinned to 2.0.27-1.fc40 for ppc64le so that we could get a build.

Also we are still seeing kdump.crash failure for aarch64

coreos/fedora-coreos-tracker#1430 should be fixed by kexec-tools 2.0.27, which we now have and coreos/fedora-coreos-tracker#1560 should be fixed by a recent selinux RPM update.

Can you look into the failures to confirm they are the same?

@dustymabe
Copy link
Member

Also we are still seeing kdump.crash failure for aarch64

coreos/fedora-coreos-tracker#1430 should be fixed by kexec-tools 2.0.27, which we now have and coreos/fedora-coreos-tracker#1560 should be fixed by a recent selinux RPM update.

ahh yes. the denial is just for stable, testing, testing-devel where we don't have kexec-tools 2.0.27 yet. So extending that denial makes sense.

@gursewak1997
Copy link
Member Author

gursewak1997 commented Oct 25, 2023 •
edited
Loading

Right, the builds fail with 2.0.27-3.fc40 but we pinned to 2.0.27-1.fc40 for ppc64le so that we could get a build.

True, apparently the problem now is that due to coreos/fedora-coreos-tracker#1598, we cannot get past cosa build step and test the kdump.crash, hence why I extended the ppc64le denylist entry.
Since, we have the version pinned to the previous version, the test will fail.

@dustymabe
Copy link
Member

True, apparently the problem now is that due to coreos/fedora-coreos-tracker#1598, we cannot get past cosa build step and test the kdump.crash, hence why I extended the ppc64le denylist entry. Since, we have the version pinned to the previous version, the test will fail.]

The build failure shouldn't matter much here. We are pinned on the previous version, but IIUC the 2.0.27-3.fc40 kexec-tools doesn't actually have any fixes. We need a fixed kernel for that and it's not really fixed upstream yet.

@dustymabe
Copy link
Member

I think we just need to update the commit message here and then we can merge this.

@gursewak1997
denylist: extend snoozes for kdump.crash
c919d84 
For rawhide ppc64le failure, we don't have a fixed
kernel yet. For the aarch64 selinux failure, it's
been fixed in kexec-tools 2.0.27 which is now in F39.
Will remove this once the prod streams have moved to F39
@gursewak1997 gursewak1997 force-pushed the kdump-snooze-extend-ppc64le branch from a234169 to c919d84 Compare October 25, 2023 16:41
dustymabe
dustymabe approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gursewak1997 gursewak1997 merged commit 6b1b56b into coreos:testing-devel Oct 25, 2023
2 checks passed
@gursewak1997 gursewak1997 deleted the kdump-snooze-extend-ppc64le branch February 13, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gursewak1997 @dustymabe