[next-devel] overrides: fix grub2 arch specific overrides #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't have any grub2 overrides in the manifest-lock.overrides.yaml file because there are no grub2 packages on s390x. Let's move those into the arch specific overrides files and also correct a few of them. Fixes 31802d2
aaradhak
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
LGTM
Cross-checked if we have everything with the below list generated by the overrides.py script.
'x86_64': {'grub2-tools-minimal', 'grub2-pc', 'grub2-common', 'grub2-pc-modules', 'grub2-tools', 'grub2-efi-x64'},
'ppc64le': {'grub2-ppc64le', 'grub2-tools-minimal', 'grub2-common', 'grub2-tools', 'grub2-ppc64le-modules'},
'aarch64': {'grub2-efi-aa64', 'grub2-common', 'grub2-tools', 'grub2-tools-minimal'}}
|
CI already passed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't have any grub2 overrides in the manifest-lock.overrides.yaml file because there are no grub2 packages on s390x. Let's move those into the arch specific overrides files and also correct a few of them.
Fixes 31802d2