upgrade: add experimental option to reset overrides

experimental ex-reset-overrides option allows resetting overrides before upgrading

Signed-off-by: Rafael G. Ruiz <[email protected]>

src/app/rpmostree-builtin-upgrade.cxx

@@ -43,6 +43,7 @@ static gboolean opt_download_only;
 static char *opt_automatic;
 static gboolean opt_lock_finalization;
 static gboolean opt_bypass_driver;
+static gboolean opt_ex_reset_overrides;
 
 /* "check-diff" is deprecated, replaced by "preview" */
 static GOptionEntry option_entries[] = {
@@ -60,6 +61,7 @@ static GOptionEntry option_entries[] = {
   { "trigger-automatic-update-policy", 0, G_OPTION_FLAG_HIDDEN, G_OPTION_ARG_NONE, &opt_automatic, "For automated use only; triggered by automatic timer", NULL },
   { "lock-finalization", 0, G_OPTION_FLAG_HIDDEN, G_OPTION_ARG_NONE, &opt_lock_finalization, "Prevent automatic deployment finalization on shutdown", NULL },
   { "bypass-driver", 0, 0, G_OPTION_ARG_NONE, &opt_bypass_driver, "Force an upgrade even if an updates driver is registered", NULL},
+  { "ex-reset-overrides", 0, G_OPTION_FLAG_HIDDEN, G_OPTION_ARG_NONE, &opt_ex_reset_overrides, "Reset overrides before upgrade", NULL },
   { NULL }
 };
 
@@ -174,6 +176,7 @@ rpmostree_builtin_upgrade (int             argc,
       g_variant_dict_insert (&dict, "download-only", "b", opt_download_only);
       g_variant_dict_insert (&dict, "lock-finalization", "b", opt_lock_finalization);
       g_variant_dict_insert (&dict, "initiating-command-line", "s", invocation->command_line);
+      g_variant_dict_insert (&dict, "ex-reset-overrides", "b", opt_ex_reset_overrides);
       g_autoptr(GVariant) options = g_variant_ref_sink (g_variant_dict_end (&dict));
 
       /* Use newer D-Bus API only if we have to. */

src/daemon/rpmostreed-transaction-types.cxx

@@ -1342,8 +1342,8 @@ deploy_transaction_execute (RpmostreedTransaction *transaction,
             return FALSE;
         }
     }
-
-  if (no_overrides)
+  const gboolean ex_reset_overrides = vardict_lookup_bool (self->options, "ex-reset-overrides", FALSE);
+  if (no_overrides || (is_upgrade && ex_reset_overrides))
     {
       if (!rpmostree_origin_remove_all_overrides (origin, &changed, error))
         return FALSE;
@@ -1440,7 +1440,7 @@ deploy_transaction_execute (RpmostreedTransaction *transaction,
       if (override_replace_local_pkgs)
         {
           g_autoptr(GPtrArray) pkgs = NULL;
-        if (!import_many_local_rpms (repo, override_replace_local_pkgs, &pkgs,
+          if (!import_many_local_rpms (repo, override_replace_local_pkgs, &pkgs,
                                        cancellable, error))
             return FALSE;