DOM manipulation removal #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willespencer when do you think it will be ready? I might want to touch some of the files soon. |
willespencer
commented
Nov 9, 2020
There was a problem hiding this comment.
@SamChou19815 I'll get it ready for review by the dev meeting!
|
[diff-counting] Significant lines: 242. |
|
[deployment-bot] Deployed to https://cornell-dti.github.io/course-plan/170/index.html |
|
@willespencer I think it's better for this PR to stop here. It's already start to get big and is blocking some other refactors I plan to do. |
willespencer
commented
Nov 10, 2020
There was a problem hiding this comment.
@SamChou19815 Agreed! Just making sure I document the remaining issues and things I have figured tried/figured out in this PR and on Monday, and then I'll mark it ready to review 😄.
SamChou19815
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove most of the existing bad DOM Manipulation code in the codebase and replace it with event handling per issue #10. This will make it much easier in the future to see and change how data flows between components.
document.getElementByIDor.innerHTMLthat grabs and manipulates data poorly, especially in opening/closing modals$parentreferences.<semester>s, NewCustomCourse.vue, etc.)Modal.vue,NewCourse.vue, andOnboardingTransfer.vue(waiting for @hahnbeelee's work to be finished before messing around with this file, will take significant more work than these other elements, see Monday)createCourseso it is not called with$parent(@SamChou19815 do you want to take this?)Test Plan
Ensure that everything works on the site compared to master (https://cornelldti-courseplan-dev.web.app/) with the exception of clicking outside of modals closing them.
Check if all of the following modals can be opened, closed, and used as expected
Notes
The rest of the DOM Manipulation should be removed so it is not duplicated in the future like it has been since CoursePlan started.
Breaking Changes
As specified above, just clicking outside of modals.