Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run prettier script on vue files (wave 1) #166

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Run prettier script on vue files (wave 1) #166

merged 1 commit into from
Nov 6, 2020

Conversation

SamChou19815
Copy link
Contributor

@SamChou19815 SamChou19815 commented Nov 5, 2020 •
edited
Loading

Summary

Let's format first wave of vue files that isn't touched and won't be touched recently.
Files that are left out in this wave:

  • src/components/Course.vue
  • src/components/Dashboard.vue
  • src/components/Modals/CourseMenu.vue
  • src/components/Modals/Modal.vue
  • src/components/Modals/NewCourse.vue
  • src/components/Modals/Onboarding.vue
  • src/components/Modals/OnboardingBasic.vue
  • src/components/Modals/OnboardingTransfer.vue
  • src/components/RequirementHeader.vue
  • src/components/RequirementView.vue
  • src/components/Requirements.vue
  • src/components/EditSemester.vue
  • src/components/DeleteSemester.vue
  • src/components/NewSemester.vue
  • src/components/Semester.vue
  • src/components/SemesterView.vue
  • src/components/SubRequirement.vue

Test Plan

CI

Notes

If you plan to touch any files in this wave, please let me know and I can revert the format.

@SamChou19815 SamChou19815 requested a review from a team as a code owner November 5, 2020 04:58
@dti-github-bot
Copy link
Member

dti-github-bot commented Nov 5, 2020 •
edited
Loading

[diff-counting] Significant lines: 427.

@dti-github-bot
Copy link
Member

[deployment-bot] Deployed to https://cornell-dti.github.io/course-plan/166/index.html

willespencer
willespencer requested changes Nov 6, 2020
View reviewed changes
Copy link
Member

@willespencer willespencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! So I think @rmz38 is working on the onboarding vue files right now for AP/IB credit frontend (per #159), and I also updated some of the other files for my DOM manipulation removal (that I just made draft PR #170 for in case you wanted to see). I can get mine fixed up by Saturday if you wanted to wait, or do it after if you thought that was better, but I'm not sure about Rose's work. What do you think the best plan is here?

@SamChou19815
Copy link
Contributor Author

Hey! So I think @rmz38 is working on the onboarding vue files right now for AP/IB credit frontend (per #159), and I also updated some of the other files for my DOM manipulation removal (that I just made draft PR #170 for in case you wanted to see). I can get mine fixed up by Saturday if you wanted to wait, or do it after if you thought that was better, but I'm not sure about Rose's work. What do you think the best plan is here?

I will revert those changes for now.

@SamChou19815 SamChou19815 merged commit 98def8d into master Nov 6, 2020
@SamChou19815 SamChou19815 deleted the vue-prettier-format branch November 6, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willespencer willespencer willespencer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamChou19815 @dti-github-bot @willespencer