Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of directive shorthands #16

Closed
kungpaogao opened this issue Dec 11, 2019 · 0 comments
Closed

Inconsistent use of directive shorthands #16

kungpaogao opened this issue Dec 11, 2019 · 0 comments
Assignees
Labels
code Code fixes and improvements

Comments

@kungpaogao
Copy link
Member

kungpaogao commented Dec 11, 2019

There is inconsistent use of directive shorthands (i.e., @ for v-on:, : for v-bind:, # for v-slot:). Read more here: https://vuejs.org/v2/style-guide/#Directive-shorthands-strongly-recommended.

Login.vue

This uses shorthand @ for v-on:.

<div class="login-container">
<button @click="socialLogin" class="social-button">
<img alt="Google Logo" src="../assets/google-logo.png" />
</button>
<div class="login-description">Continue With Google Sign-In</div>
</div>

Dashboard.vue

This also uses shorthand.

<div id="dashboard-mainView">
<semesterview
:semesters="semesters"
:compact="compactVal"
@compact-updated="compactVal = $event"
/>
<requirements />
</div>

Semester.vue

This one uses a mix of both? (sometimes opting for :, but mostly v-bind:

<modal :id="'courseModal-' + id" class="semester-modal" type="course" :semesterID="id" />
<confirmation
:id="'confirmation-' + id"
class="semester-confirmation"
:text="confirmationText"
/>
<div v-if="isNotSemesterButton" class="semester-content">
<div class="semester-top" v-bind:class="{ 'semester-top--compact': compact }">
<div class="semester-left" v-bind:class="{ 'semester-left--compact': compact }">
<span class="semester-name">{{ type }} {{ year }}</span>
<img class="semester-icon" src="../assets/images/pencil.svg" />
</div>
<div class="semester-right" v-bind:class="{ 'semester-right--compact': compact }">
<span class="semester-credits">{{ creditString }}</span>
</div>
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code fixes and improvements
Projects
None yet
Development

No branches or pull requests

4 participants