Make all directives (v-bind, v-on) use shorthand #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kungpaogao
requested review from
SamChou19815,
willespencer,
boonakij and
handotdev
|
Wait, for some reason |
|
I need to update |
SamChou19815
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
LGTM. Didn't know that exists. Let's wait until @boonakij looks at it.
kungpaogao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is just a fix aimed at addressing issue #16. I have changed all
v-bindandv-onto use their corresponding shorthand:and@.Test Plan
Everything should work as before. This just modifies the code style, not the functionality.
Notes
If you merge this PR, please stick to using the shorthand in future code.