[easy] Annotate all vue templates props as required #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 69. |
|
Visit the preview URL for this PR (updated for commit feebf06): https://cornelldti-courseplan-dev--pr287-all-props-required-9pkt7s9p.web.app (expires Sat, 20 Feb 2021 20:10:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
SamChou19815
force-pushed
the
all-props-required
branch
from
64ea275 to
feebf06
Compare
tcho6319
approved these changes
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continue the work in #279, I annotated all props as required. This ensures that console will emit warnings when you forget to pass in the props.
Test Plan
Move around the app. No warnings in console, which shows that these annotations are accurate.