[CI Fix] Update CUReviews API and Update Node Version #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 4. |
|
Visit the preview URL for this PR (updated for commit a31752a): https://cornelldti-courseplan-dev--pr886-andrew-fix-tests-j3pkyowl.web.app (expires Thu, 14 Mar 2024 18:11:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
zachary-kent
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on Zak's PR here, but for some reason WIP wasn't passing. :/
#884
Updates a reference to CUReviews' API; see here. We should merge this and release ASAP, as the bottom bar is currently broken in prod. Closes #885
It also bumps the node version in our snapshot action so that the checks don't fail. Unfortunately, I have to make both of these changes in the same PR so we can merge. Gross, I know.
Test Plan
Check the bottom bar works now locally