merge collection frontend and backend #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- can save a course when press 'done' - course is saved to an empty collection - add functions for add & edit collection
- can save one course to multiple collections w/ checkbox - saved course will be removed from semester view and from fullfilled requirements - pop up notification
- finished scrollable checkbox frontend - fixed the bug for selecting a singular checkbox - believed its stored in firestore when added to collection - renamed collection to savedCourses for firesetore clarity
- saveCourseModal allow user to name their new collections - moved scss into a separate file
- added updateDoc in backend functions - made edit Collections modal more functional with saveCourse
|
[diff-counting] Significant lines: 800. |
|
Visit the preview URL for this PR (updated for commit aa42b8c): https://cornelldti-courseplan-dev--pr951-hannah-merge-collec-k0z28qt0.web.app (expires Thu, 28 Nov 2024 21:16:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
Simon draggable saved courses
…rse-plan into hannah--merge-collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is one of the final steps in implementing saved courses
Small Little Demo:
CoursePlan.and.18.more.pages.-.Personal.-.Microsoft.Edge.2024-10-28.03-00-39.mp4
Demo with firestore:
Screen.Recording.2024-10-27.231911.mp4
Remaining TODOs:
Depends on #{number of PR}
Test Plan
Enable the saved course icon with
GK.enableSavedCourses();in the console.Now you should be able to see the saved icon on the sidebar :)
Please run in terminal
npm run ts-node scripts/migration/savedCourses-migration.ts -- [email protected]to get a default Collection. if you don't do this courseplan will crash D': (That was me this entire afternoon)Make sure you can see
savedCoursesin firestoreNotes
Blockers
Breaking Changes