Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapped dot menu in a div to fix stretching problem #404

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Wrapped dot menu in a div to fix stretching problem #404

merged 1 commit into from
Oct 8, 2020

Conversation

nada-attia
Copy link
Member

Summary

Fixed issue #400 by wrapping the dot menu in a div.

Test Plan

Tested this on professor, TA, and student view, and the dot menu no longer appears stretched.

Notes

Breaking Changes

None

  • I have updated the documentation accordingly.
  • My PR adds a @ts-ignore

@nada-attia nada-attia requested a review from a team as a code owner October 8, 2020 12:27
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 2.

ngwattcos
ngwattcos approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@ngwattcos ngwattcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I've tested your fix and it works.

@nada-attia nada-attia merged commit e4a7ede into add_ta_comments Oct 8, 2020
@nada-attia nada-attia deleted the nada/fix-dot-menu branch October 8, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngwattcos ngwattcos ngwattcos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nada-attia @dti-github-bot @ngwattcos