Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor firebasefunctions file #523

Merged
merged 2 commits into from
Mar 21, 2021
Merged

Refactor firebasefunctions file #523

merged 2 commits into from
Mar 21, 2021

Conversation

nada-attia
Copy link
Member

@nada-attia nada-attia commented Mar 21, 2021

Summary

The firebasefunctions file was getting too long. This PR creates a firebasefunctions folder and breaks up the firebasefunctions file into smaller files (each file contains related functions). I also updated the import statements in component files to match the path of the functions imported.

Test Plan

This PR does not add any new functionality; it just breaks up the code into smaller files. To test this change make sure that the app builds and there are no breaking changes.

Notes

Breaking Changes

None

  • I have updated the documentation accordingly.
  • My PR adds a @ts-ignore

@nada-attia nada-attia requested a review from a team as a code owner March 21, 2021 06:30
@dti-github-bot
Copy link
Member

dti-github-bot commented Mar 21, 2021

[diff-counting] Significant lines: 619.

Copy link
Member

@ngwattcos ngwattcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, Nada! This gives us a great basis to continue refactoring the remaining components.

@nada-attia nada-attia merged commit 474924f into master Mar 21, 2021
@nada-attia nada-attia deleted the nada/firebasefunctions branch March 21, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants