Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtype/device mismatch in _get_indices() #90

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Fix dtype/device mismatch in _get_indices() #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a50952e
Fix dtype/device mismatch in _get_indices()
Turakar Jan 8, 2024
82cfbc2
Merge branch 'main' into fix_diag-linop-device
gpleiss Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion linear_operator/operators/diag_linear_operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,12 @@ def _diagonal(self: Float[LinearOperator, "... M N"]) -> Float[torch.Tensor, "..

def _get_indices(self, row_index: IndexType, col_index: IndexType, *batch_indices: IndexType) -> torch.Tensor:
res = self._diag[(*batch_indices, row_index)]
# Unify device and dtype prior to comparison
row_index = row_index.to(device=res.device, dtype=res.dtype)
col_index = col_index.to(device=res.device, dtype=res.dtype)
# If row and col index don't agree, then we have off diagonal elements
# Those should be zero'd out
res = res * torch.eq(row_index, col_index).to(device=res.device, dtype=res.dtype)
res = res * torch.eq(row_index, col_index)
return res

def _mul_constant(
Expand Down
Loading